Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeORM 0.3.0 support #790

Open
andrewvasilchuk opened this issue Jun 3, 2022 · 13 comments
Open

TypeORM 0.3.0 support #790

andrewvasilchuk opened this issue Jun 3, 2022 · 13 comments

Comments

@andrewvasilchuk
Copy link

TypeORM 0.3.0 version was released. It would be great to add support for this version.

@zaro
Copy link

zaro commented Jun 17, 2022

My company is heavy user of this library, and since it's practically abandoned we decided to fork it.
I've published today, alpha version with TypeORM 0.3x. support.

You can find the fork here : https://github.com/gid-oss/dataui-nestjs-crud , instructions how to use the 0.3.x version in the Readme.

Cheers.

@fscardua
Copy link

Very good, but I try to use your fork and there's an error on start compilation

Starting compilation in watch mode...

node_modules/@dataui/crud/lib/interfaces/auth-options.interface.d.ts:2:31 - error TS2307: Cannot find module 'crud-util/src' or its corresponding type declarations.

2 import { ObjectLiteral } from 'crud-util/src';

@yepes
Copy link

yepes commented Jul 13, 2022

There are some forks that support type orm >0.3.x out there. Most of them have some problems that make then not production ready. Is this something that is going to be implemented? or should we look somewhere else?

@zaro
Copy link

zaro commented Jul 13, 2022

@fscardua this is fixed in the latest alpha

MrMaz added a commit to conceptadev/nestjsx-crud that referenced this issue Jul 25, 2022
TypeORM has been upgraded to ^0.3.0. Nest has been upgraded to ^9.0.0. Minor changes to TypeORM crud
service related to unique select columns. Major changes to tests to support new DataSource
configuration.

BREAKING CHANGE: TypeORM v0.3.0 came with many breaking changes, please see their release notes for
more details. https://github.com/typeorm/typeorm/releases/tag/0.3.0

re nestjsx#790
@MrMaz
Copy link

MrMaz commented Jul 25, 2022

@zaro it would be great if you could review my PR and lmk if you have found any other issues. my PR passes all test for Postgres and MySQL on all ^0.3.X versions.

@zaro
Copy link

zaro commented Jul 26, 2022

@MrMaz I don't have any contributor rights for this repo and I belive it is abandoned. I try to maintain a fork here : https://github.com/gid-oss/dataui-nestjs-crud, and there is already some support for typeorm 0.3 in the alpha prereless version.

@MrMaz
Copy link

MrMaz commented Jul 26, 2022

@zaro i am in contact with the author, he had to flee Ukraine because of the war. i am going to inquire with him if there is any appetite to move this forward short term, or if it will be a while.

it would be great to compare notes with you on what TypeORM 0.3 issues you have needed to solve so far.

@zaro
Copy link

zaro commented Jul 26, 2022

@MrMaz good. Maybe you can sort it out, but the reality is the package was abandoned months before the war started, so I don't think the war has anything to do with that.

@gregsj
Copy link

gregsj commented Aug 15, 2022

@MrMaz any update?

@gregsj
Copy link

gregsj commented Aug 16, 2022

@zaro testing your fork with 0.3 and so far so good. Thanks

@JensWunderwald
Copy link

my company also uses this library intensively.

I would appreciate any information when dataui-nestjs-crud will reach the release stage.

@zaro
Copy link

zaro commented Sep 29, 2022

@JensWunderwald it's in the bakclog, since we haven't moved to typeorm 0.3. So I made o ly preliminary testing and haven't released it yet because of lack of more testing ( only baic things have been tested so far) . But if it works for you this way I'm going to release it.

@jinpy666
Copy link

There are safety issues.

Package Type Update Change
typeorm (source) dependencies minor ^0.2.42 -> ^0.3.0

Package Type Update Change
typeorm (source) dependencies minor ^0.2.42 -> ^0.3.0
By merging this PR, the below vulnerabilities will be automatically resolved:

Severity CVSS Score CVE
High 9.8 CVE-2022-33171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants