Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt relative paths resolution to tsconfig outDir depth #2706

Open
2 of 4 tasks
mgrisole opened this issue Nov 14, 2023 · 3 comments
Open
2 of 4 tasks

Adapt relative paths resolution to tsconfig outDir depth #2706

mgrisole opened this issue Nov 14, 2023 · 3 comments
Labels
bug needs triage

Comments

@mgrisole
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

This issue is almost a duplicate of #2114, I can't figure out why this should be address in Discord since it is a real bug and we are facing exactly the same issue in a pnpm workspace.

I can get it working by performing this manual change on dist:

  • Open apps/nest/dist/src/app.controller.js
  • Change require("../../../packages/math-helpers/dist/index").Me to require("../../../../packages/math-helpers/dist/index").Me

Possible related issues:
#1386
#501

Minimum reproduction code

https://github.com/bindermuehle/monorepo-issue

Steps to reproduce

  1. npm i
  2. npm run start:dev -w nest

Expected behavior

nest/swagger should correctly resolve the paths

Package version

7.1.10

NestJS version

9.0.0

Node.js version

20.9.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response
@mgrisole
Copy link
Author

mgrisole commented Nov 14, 2023 •
edited
Loading

Removing one of these two statements fixes the issue, but I fail to understand the whole context at the moment:

swagger/lib/plugin/utils/plugin-utils.ts

Lines 153 to 155 in c4cbca6

if (isAbsolute(importPath)) {
throw {};
}

swagger/lib/plugin/utils/plugin-utils.ts

Line 192 in c4cbca6

typeReference = typeReference.replace(importPath, relativePath);

mgrisole added a commit to mgrisole/swagger that referenced this issue Nov 14, 2023
@mgrisole
fix: adapt imports replacement with tsconfig outDir depth
667e81b 
nestjs#2706
@mgrisole mgrisole mentioned this issue Nov 14, 2023
Closed
12 tasks
mgrisole added a commit to mgrisole/swagger that referenced this issue Nov 14, 2023
@mgrisole
fix: adapt imports replacement with tsconfig outDir depth
18f4364 
fixes nestjs#2706
mgrisole added a commit to mgrisole/swagger that referenced this issue Nov 14, 2023
@mgrisole
fix: adapt imports replacement with tsconfig outDir depth
c5b171a 
Closes nestjs#2706
@mgrisole mgrisole changed the title Wrong path resolution in monorepo Adapt relative paths resolution to tsconfig outDir depth Nov 15, 2023
@aqeelat
Copy link

aqeelat commented Jul 22, 2024

@kamilmysliwiec We're also facing this issue.

We have a schemas package that's used in our frontends and backends.

Until this is fixed, our only options are:

  1. moving the entire package inside the nest src folder (bad idea)
  2. adding a path alias in tsconfig that points to the schemas package (also a bad idea)

@jkalberer
Copy link

This is a clear bug and I don't know why this PR was closed without any comment.

@aqeelat - can you give an example of the second option? (I'm trying to add paths to my tsconfig but can't figure it out)
It's definitely not ideal but it beats waiting for this bug to actually get addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adapt imports replacement with tsconfig outDir depth mgrisole/swagger
3 participants
@aqeelat @mgrisole @jkalberer