Added smaller and greater Operator to DateTimeImmutable Type and Value

Author: TimoLehnertz

src/type/CompoundType.php

@@ -172,4 +172,3 @@ protected function getProperties(): ?array {
     return ['types' => $types];
   }
 }
-

src/type/DateIntervalType.php

@@ -19,10 +19,6 @@ public function equals(Type $type): bool {
     return $type instanceof DateIntervalType;
   }
 
-  // public function getImplementedOperators(): array {
-  //   return [];
-  // }
-
   protected function getTypeCompatibleOperands(ImplementableOperator $operator): array {
     switch ($operator->getID()) {
       case ImplementableOperator::TYPE_TYPE_CAST:

src/type/DateTimeImmutableType.php

@@ -5,7 +5,6 @@
 namespace TimoLehnertz\formula\type;
 
 use TimoLehnertz\formula\operator\ImplementableOperator;
-use const false;
 
 /**
  * @author Timo Lehnertz
@@ -25,6 +24,9 @@ protected function getTypeCompatibleOperands(ImplementableOperator $operator): a
       case ImplementableOperator::TYPE_ADDITION:
       case ImplementableOperator::TYPE_SUBTRACTION:
         return [new DateIntervalType()];
+        case ImplementableOperator::TYPE_GREATER:
+        case ImplementableOperator::TYPE_LESS:
+        return [new DateTimeImmutableType()];
       case ImplementableOperator::TYPE_TYPE_CAST:
         return [new TypeType(new IntegerType())];
       default:
@@ -40,6 +42,12 @@ protected function getTypeOperatorResultType(ImplementableOperator $operator, ?T
           return new DateTimeImmutableType();
         }
         break;
+      case ImplementableOperator::TYPE_GREATER:
+      case ImplementableOperator::TYPE_LESS:
+        if ($otherType instanceof DateTimeImmutableType) {
+          return new BooleanType();
+        }
+        break;
       case ImplementableOperator::TYPE_TYPE_CAST:
         if ($otherType instanceof TypeType && $otherType->getType() instanceof IntegerType) {
           return new IntegerType();

src/type/DateTimeImmutableValue.php

@@ -30,6 +30,16 @@ protected function valueOperate(ImplementableOperator $operator, ?Value $other):
           return new DateTimeImmutableValue($this->value->sub($other->toPHPValue()));
         }
         break;
+      case ImplementableOperator::TYPE_LESS:
+        if ($other instanceof DateTimeImmutableValue) {
+          return new BooleanValue($this->value < $other->toPHPValue());
+        }
+        break;
+      case ImplementableOperator::TYPE_GREATER:
+        if ($other instanceof DateTimeImmutableValue) {
+          return new BooleanValue($this->value > $other->toPHPValue());
+        }
+        break;
       case ImplementableOperator::TYPE_TYPE_CAST:
         if ($other instanceof TypeValue && $other->getValue() instanceof IntegerType) {
           return new IntegerValue($this->value->getTimestamp());

test/type/TypeTest.php

@@ -268,6 +268,17 @@ public function provider(): array {
     $compatibleOperands = [];
     $compatibleOperands[] = new CompatibleOperator(new DateIntervalType(), new DateTimeImmutableType(), new DateIntervalValue(new \DateInterval('P1D')), new DateTimeImmutableValue(new \DateTimeImmutable('2024-01-04')));
     $operators[] = new OperatorTestMeta(ImplementableOperator::TYPE_SUBTRACTION, $compatibleOperands);
+    // Operator <
+    $compatibleOperands = [];
+    $compatibleOperands[] = new CompatibleOperator(new DateTimeImmutableType(), new BooleanType(), new DateTimeImmutableValue(new \DateTimeImmutable('2024-01-01')), new BooleanValue(false));
+    $compatibleOperands[] = new CompatibleOperator(new DateTimeImmutableType(), new BooleanType(), new DateTimeImmutableValue(new \DateTimeImmutable('2024-01-06')), new BooleanValue(true));
+    $operators[] = new OperatorTestMeta(ImplementableOperator::TYPE_LESS, $compatibleOperands);
+    // Operator >
+    $compatibleOperands = [];
+    $compatibleOperands[] = new CompatibleOperator(new DateTimeImmutableType(), new BooleanType(), new DateTimeImmutableValue(new \DateTimeImmutable('2024-01-01')), new BooleanValue(true));
+    $compatibleOperands[] = new CompatibleOperator(new DateTimeImmutableType(), new BooleanType(), new DateTimeImmutableValue(new \DateTimeImmutable('2024-01-05')), new BooleanValue(false));
+    $operators[] = new OperatorTestMeta(ImplementableOperator::TYPE_GREATER, $compatibleOperands);
+    
     // Operator (int)
     $compatibleOperands = [];
     $compatibleOperands[] = new CompatibleOperator(new TypeType(new IntegerType()), new IntegerType(), new TypeValue(new IntegerType()), new IntegerValue((new \DateTimeImmutable('2024-01-05'))->getTimestamp()));
@@ -454,6 +465,7 @@ public function testTypes(mixed $phpValue, Type $type, Type $equal, Type $notEqu
            */
           if (!$compatibleOperand->expectedRetult->valueEquals($resultValue)) {
             var_dump($compatibleOperand->expectedRetult, $resultValue);
+            var_dump($testValue);
           }
           $this->assertTrue($compatibleOperand->expectedRetult->valueEquals($resultValue));
         }