Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next NuGet release #23

Open
ScrubN opened this issue Mar 2, 2023 · 3 comments
Open

Next NuGet release #23

ScrubN opened this issue Mar 2, 2023 · 3 comments

Comments

@ScrubN
Copy link

ScrubN commented Mar 2, 2023

When is the next NuGet release planned to be published? Unicode 14 emojis + the performance improvements from 15ca8e5 would be very appreciated.

@mqudsi
Copy link
Member

mqudsi commented Mar 16, 2023

I'm happy to release an update on nuget w/ the latest unicode update but there are questions about #10 that prevent it from being as simple as you think.

It's a really old pull request and most of the memory improvements have already been inlined into the code (via the same approach or different approaches altogether). Also some of the changes are not technically correct or necessary, for example, string interning at compile-time already coalesces duplicated (static/const) strings (you can check this by comparing memory addresses at run-time or using String.IsInterned()).

You can't just add HasGlyph because that is contingent on the font used, and the version thereof. If you want to take a look at that PR and see what can be used and what can't, we can tackle them individually (not as one massive PR).

@sunkhaskasis
Copy link
Contributor

@COM8 Could you have a look, if you have the time?

@COM8
Copy link
Contributor

COM8 commented Mar 16, 2023

@sunkhaskasis I added it to my backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants