Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GUTTER_PX (refactor) #472

Open
4 tasks
falconx opened this issue Aug 20, 2020 · 0 comments
Open
4 tasks

Remove GUTTER_PX (refactor) #472

falconx opened this issue Aug 20, 2020 · 0 comments
Labels
Improvement Making an existing feature better

Comments

@falconx
Copy link
Contributor

falconx commented Aug 20, 2020

Plan

  • Remove the GUTTER_PX variable from theme.js
  • Update any references to GUTTER_PX by replacing them with a rem equivalent
  • Define a spacing unit value or scale (array) at theme.js
  • Reference the spacing unit value/scale everywhere that we're defining spacing within our UI
@falconx falconx added the Improvement Making an existing feature better label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Making an existing feature better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@falconx