Clicking "Start over" results in duplicate Resume modal

[Hoolean]

Problem

When a user is greeted with the resume modal (at /#resume, labelled "Hello again"), pressing "Start over" just leads them back to the same dialog. They must press it a further time to reach the home page.

Further Implications

The dialog occasionally appears unexpectedly when running Grunt tests for SEAP ESA, failing them. I suspect this could be caused by the same issue.

Reproducing

1. Navigate to the live SEAP ESA website
2. If you are not presented with the modal:
   1. Answer some questions on the site
   2. Close your tab
   3. Navigate to the site again

Expected

The user is taken to the home page.

Actual

The user is returned to the modal.

Note that the URL has still changed from http://www.esa-assessment.support/#resume to http://www.esa-assessment.support/#main-menu.

Further Thoughts

• Is the other button functioning correctly?
• Should the button do anything other than redirect the user to the main menu?

Environment

• Firefox v69.0.1 (admittedly with some add-ons)
• Ubuntu 19.04

[katjam]

I think we have to leave any flow stuff for a rewrite at this point. Historically fixing one part of flow broke other parts.