Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bug ] .withTabsImage needs to be patched. It doesn't actually do anything. #2004

Open
kobaltromero opened this issue Mar 5, 2025 · 1 comment
Labels
1.20.4 Targeted at Minecraft 1.20.4 1.20.5 Targeted at Minecraft 1.20.5 1.20.6 Targeted at Minecraft 1.20.6 1.21 Targeted at Minecraft 1.21 1.21.1 Targeted at Minecraft 1.21.1 1.21.2 Targeted at Minecraft 1.21.2 1.21.3 Targeted at Minecraft 1.21.3 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error rendering Related to rendering

Comments

@kobaltromero
Copy link

public static final DeferredHolder<CreativeModeTab, CreativeModeTab> MATTERZ = CREATIVE_MODE_TABS.register("matterz",() -> CreativeModeTab.builder()
            .withTabsBefore(CreativeModeTabs.SPAWN_EGGS)
            .withTabsImage(ResourceLocation.fromNamespaceAndPath(ID, "textures/gui/matterz.png"))
@kobaltromero kobaltromero added the triage Needs triaging and confirmation label Mar 5, 2025
@ChampionAsh5357 ChampionAsh5357 added bug A bug or error rendering Related to rendering 1.21 Targeted at Minecraft 1.21 1.20.4 Targeted at Minecraft 1.20.4 1.20.5 Targeted at Minecraft 1.20.5 1.20.6 Targeted at Minecraft 1.20.6 1.21.1 Targeted at Minecraft 1.21.1 1.21.2 Targeted at Minecraft 1.21.2 1.21.3 Targeted at Minecraft 1.21.3 1.21.4 Targeted at Minecraft 1.21.4 and removed triage Needs triaging and confirmation labels Mar 5, 2025
@ChampionAsh5357
Copy link
Contributor

So this is because the tabs are now sprites. Not just one mind you, but 28: 7 for top tabs in each position, 7 for bottom tabs in each position, and another 14 for their selected/unselected variant. Trying to replace that easily is a hard question since defining 28 textures in CreativeModeTab is a bit ridiculous. I could either see this as we define a 'directory' to which the default sprite locations are appended or we add a method like IClientCreativeModeTabExtensions#renderTabButton that handles it. Which makes the most sense needs further discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.4 Targeted at Minecraft 1.20.4 1.20.5 Targeted at Minecraft 1.20.5 1.20.6 Targeted at Minecraft 1.20.6 1.21 Targeted at Minecraft 1.21 1.21.1 Targeted at Minecraft 1.21.1 1.21.2 Targeted at Minecraft 1.21.2 1.21.3 Targeted at Minecraft 1.21.3 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error rendering Related to rendering
Projects
None yet
Development

No branches or pull requests

2 participants