• Publish PR to GitHub Packages

Is there the potential for any other kind of exception to be thrown here? Wondering if we should just expand it to Exception and be done with it.

Is there the potential for any other kind of exception to be thrown here? Wondering if we should just expand it to Exception and be done with it.

I didn't dig for very long, but nothing stood out to me. I generally don't like blanket catches, as it's too easy for them to hide real issues. Better only cover all known exceptions and treat everything else as a bug that needs to be reported to be fixed by default.

Even for this one, one could argue we should check the data so the exception doesn't happen instead of catching it. And at work, I'd be one of those people.

I'm leaning towards the same thought there: rethrow the exception with a better message rather than hiding an invalid path.

However, that validation should be done by FML on mod loading rather than the mod list screen.