Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c:fertilizers tag #1135

Open
ferriarnus opened this issue Jun 18, 2024 · 4 comments
Open

Add c:fertilizers tag #1135

ferriarnus opened this issue Jun 18, 2024 · 4 comments
Labels
enhancement New (or improvement to existing) feature or request

Comments

@ferriarnus
Copy link
Contributor

Add a common tag for fertilizers. Here I mean items that act like bonemeal, by calling the appropriate methods on the bonemealable block.

@ferriarnus ferriarnus added the enhancement New (or improvement to existing) feature or request label Jun 18, 2024
@TelepathicGrunt
Copy link
Contributor

TelepathicGrunt commented Jun 18, 2024

Alternative suggestion, neoforge:fertilizers tag that when added to, will automatically make the item act like bonemeal due to us patching all the bonemeal checks to check the tag instead

@dhyces
Copy link
Contributor

dhyces commented Jun 18, 2024

If it's for behavior, I would prefer it be something like neoforge:fertilizes. I have an item that fertilizes stuff, but it itself should not be considered a fertilizer, rather it is a bag that holds fertilizers.

@TelepathicGrunt
Copy link
Contributor

a container that holds another item to use would need its own special implementation. If in neoforge:fertilizes tag and we hook all the bonemeal stuff to use it, your item will get consumed on use if added to the tag as I'm sure in the bonemeal paths, it decrements the itemstack count

@TelepathicGrunt
Copy link
Contributor

Took a look. Bonemealing is not handled by the item but by blocks implementing BonemealableBlock. Then anyone just instanceof check BonemealableBlock and call the bonemealing method on it to grow stuff. So there's no item tag functionality to hook anywhere. Makes sense for this to be a c tag actually.

@ferriarnus did you make issue report on fabric side to see if they are interested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

No branches or pull requests

3 participants