Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter #2

Open
martinohanlon opened this issue Jun 24, 2024 · 0 comments
Open

Incorrect parameter #2

martinohanlon opened this issue Jun 24, 2024 · 0 comments
Assignees

Comments

@martinohanlon
Copy link
Contributor

This function:

https://github.com/neo4j-graphacademy/llm-vectors-unstructured/blob/main/llm-vectors-unstructured/solutions/build_graph.py#L24

# tag::get_embedding[]
def get_embedding(llm, text):
    response = llm.embeddings.create(
            input=chunk.page_content,
            model="text-embedding-ada-002"
        )
    return response.data[0].embedding
# end::get_embedding[]

... doesn't use the text parameter passed to it. It still works as chunk is globally defined, but it should be changed.

@martinohanlon martinohanlon self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant