Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

British English spellings vs. American English spellings: create an en_US translation, and teach spellchecker to accept Britishisms #206

Open
cooljeanius opened this issue Jul 25, 2024 · 6 comments · May be fixed by #217
Open

British English spellings vs. American English spellings: create an en_US translation, and teach spellchecker to accept Britishisms #206

cooljeanius opened this issue Jul 25, 2024 · 6 comments · May be fixed by #217
Assignees
@cooljeanius
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.8.0

Comments

@cooljeanius
Copy link
Collaborator

whichever of my spellcheckers that wmllint is using (it looks like it might have changed from AppleSpell to Aspell?) has started complaining about various British spellings used in the add-on:

# Spell-checking with Aspell
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/09_Hired_Swords.cfg", line 331: possible misspelling "honoured" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/09_Hired_Swords.cfg", line 440: possible misspelling "honour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/16_Choosing_the_Best.cfg", line 74: possible misspelling "recognised" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/16_Choosing_the_Best.cfg", line 78: possible misspelling "recognise" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/20_Okladia.cfg", line 26: possible misspelling "behaviour." 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21a_Abducted_Bride.cfg", line 77: possible misspelling "neighbouring" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21c_Ruins_of_the_Past.cfg", line 19: possible misspelling "honour." 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21c_Ruins_of_the_Past.cfg", line 42: possible misspelling "honour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21c_Ruins_of_the_Past.cfg", line 58: possible misspelling "civilised" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/25_The_Awakening.cfg", line 298: possible misspelling "neighbouring" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/_main.cfg", line 35: possible misspelling "civilisation" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Clansman.cfg", line 18: possible misspelling "armoured" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Fastfoot.cfg", line 18: possible misspelling "armour," 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_LightInfantry.cfg", line 17: possible misspelling "armour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Shieldguard.cfg", line 24: possible misspelling "armour," 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Sturmknight.cfg", line 24: possible misspelling "armour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Warrior.cfg", line 18: possible misspelling "neighbouring" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/macros/amla.cfg", line 7: possible misspelling "Armoured"

Should I replace them with their American spellings in the source strings (breaking translations in the process), or create a separate en_US translation that uses American spellings?
@cooljeanius cooljeanius added the question Further information is requested label Jul 25, 2024
This was referenced Jul 25, 2024
Open
Closed
Open
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Jul 25, 2024
@cooljeanius
wmllint's spellchecker changed on me
7e303d7 
see nemaara/A_New_Order#206 for more info, although I'm not addressing the question I raised there at the moment
@GitMensch
Copy link

The split sounds reasonable to me

@cooljeanius
Copy link
Collaborator Author

The split sounds reasonable to me

...so, to be clear, that's the latter of the two options, correct?

@GitMensch
Copy link

A separate en_US which is based on the current en seems reasonable to me.
As you already found this will ensure that no existing translations need updates to match the new msgids.

@MultiSeptim
Copy link
Contributor

Both options suit me.

@cooljeanius
Copy link
Collaborator Author

OK, I'll start working on a separate en_US translation for the 1.8.0 release; I want to get 1.7.0 out the door first, though...

@cooljeanius cooljeanius changed the title British English spellings vs. American English spellings? British English spellings vs. American English spellings: create an en_US translation Aug 25, 2024
@cooljeanius cooljeanius added this to the 1.8.0 milestone Aug 25, 2024
@cooljeanius cooljeanius self-assigned this Aug 25, 2024
@cooljeanius cooljeanius changed the title British English spellings vs. American English spellings: create an en_US translation British English spellings vs. American English spellings: create an en_US translation, and teach spellchecker to accept Britishisms Aug 25, 2024
@cooljeanius cooljeanius added enhancement New feature or request good first issue Good for newcomers and removed question Further information is requested labels Aug 25, 2024
cooljeanius added a commit to cooljeanius/A_New_Order-1 that referenced this issue Aug 26, 2024
@cooljeanius
address issue nemaara#206
4ee93ab
@cooljeanius cooljeanius linked a pull request Aug 26, 2024 that will close this issue
Draft
@cooljeanius
Copy link
Collaborator Author

OK, I'll start working on a separate en_US translation for the 1.8.0 release; I want to get 1.7.0 out the door first, though...

Update: I opened #217 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooljeanius cooljeanius

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Branch for miscellaneous 1.18-based changes cooljeanius/A_New_Order-1
3 participants
@cooljeanius @GitMensch @MultiSeptim