Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lorin/Karen killing competition: improve dialogue #19

Open
cooljeanius opened this issue Oct 12, 2021 · 6 comments
Open

Lorin/Karen killing competition: improve dialogue #19

cooljeanius opened this issue Oct 12, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cooljeanius
Copy link
Collaborator

This can be kind of hard to test; I don't think I've actually seen all the text in-game yet:

A_New_Order/macros/ano-14macros.cfg

Lines 26 to 177 in 3b71676

#define LORIN_KAREN_COMPETITION
[event]
name=die
first_time_only=no
[filter_second]
id=Karen
[/filter_second]
{IF_HAVE_UNIT (Lady Lorin)}
{IF ano_competition equals end}
{IF ano_competition_k equals 0}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Scored!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
# FIXME: the word "again" doesn't make sense if this is the first kill of the competition:
_"Don't start again, kid. I won't play that game this time."}
{VARIABLE ano_competition_k 1}
{END_IF_WITHOUT_ELSE}
{ELSE}
{IF ano_competition_k equals 0}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"Hey, Lorin, or whatever your name is, did you see that? Now you know why underlings give weapons to 'children'!"}
{ELSE_IF ano_competition_k equals 1}
{IF ano_competition_l equals 0}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"Ha! Gawen, did you see that? I've already killed two enemies, and your step-grand-mother hasn't killed a single one!"}
{ELSE}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Ha! Scored two!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"You think it is some kind of competition?"}
{END_IF}
{ELSE_IF ano_competition_k equals 2}
{IF ano_competition_l equals 0}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"Hey, Gawen. That she-wolf of yours is pathetic. I've scored three and she hasn't killed a single enemy!"}
{ELSE}
{IF ano_competition_l greater_than 2}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Ha! Scored three!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"So what? I am winning!"}
{ELSE}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Ha! Scored three!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin) _"So what?"}
{END_IF}
{END_IF}
{ELSE}
{IF ano_competition_l greater_than $ano_competition_k}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Ha! Another one!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"So what? I am winning!"}
{ELSE_IF ano_competition_l equals 0}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"I'm a killing machine! Lorin should just go back and hide in Haeltin!"}
{ELSE}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Ha! I'm winning!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"Impertinent heathen underling child, the day has not yet ended!"}
{TWO_END_IFs}
{TWO_END_IFs}
{END_IF}
{END_IF}
{END_IF_WITHOUT_ELSE}
{VARIABLE_OP ano_competition_k add 1}
[/event]
[event]
name=die
first_time_only=no
[filter_second]
id=Lady Lorin
[/filter_second]
{IF ano_competition equals end}
{ELSE}
{IF ano_competition_l equals 0}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin) _"First kill today!"}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"Oh no, the mighty Lorin is coming! Children and little furry animals, run for your life!"}
{ELSE_IF ano_competition_l equals 1}
{IF ano_competition_k equals 0}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Karen)
_"My son, send little Karen back home. She is useless. I've killed two enemies already, and what has she done?"}
{ELSE}
{IF ano_competition_l greater_than $ano_competition_k}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"Scored! Now I'm in the lead!"}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"And I thought you weren't competing with me."}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"I am not competing with you, silly child."}
{ELSE}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"Try a little harder, grand-mother. But not bad for your age."}
{END_IF}
{END_IF}
{ELSE_IF ano_competition_l equals 2}
{IF ano_competition_l greater_than $ano_competition_k}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"Ha! She-wolf of Haeltin is coming! No underling child could be better than me!"}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"The She-wolf of Haeltin, don't get too excited; it will cause more wrinkles."}
{ELSE}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin) _"Three!"}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"Pfff! Only three?"}
{END_IF}
{ELSE}
{IF ano_competition_l greater_than $ano_competition_k}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"Who's the killing machine now?"}
{ELSE}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"Not bad, but still you have to a lot to learn!"}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"Do you think, little child, that I will honour you with an answer?"}
{END_IF}
{TWO_END_IFs}
{END_IF}
{END_IF}
{VARIABLE_OP ano_competition_l add 1}
[/event]
#enddef
#define LORIN_KAREN_COMPV
{IF ano_competition equals end}
{ELSE}
{IF_HAVE_UNIT (Lady Lorin)}
{IF ano_competition_l greater_than $ano_competition_k}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"By the way, I won. Scored $ano_competition_l"}
{MESSAGE (Majid Yahyazad) (portraits/majid.png) (Majid Yahyazad)
_"Girls, what do you exactly mean by 'scored'? Is it because you are slicing up your fallen foes?"}
{ELSE_IF ano_competition_k greater_than $ano_competition_l}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"By the way, I won. Scored $ano_competition_k"}
{MESSAGE (Majid Yahyazad) (portraits/majid.png) (Majid Yahyazad)
_"Girls, what do you exactly mean by 'scored'? Is it because you are slicing up your fallen foes?"}
{ELSE_IF ano_competition_k greater_than 0}
{MESSAGE (Gawen Hagarthen) (portraits/gawen_winter.png) (Gawen)
_"Why such an angry look, Lorin?"}
{MESSAGE (Karen) (portraits/karen.png) (Karen) _"She lost."}
{MESSAGE (Lady Lorin) (portraits/lorin_winter.png) (Lorin)
_"I have not lost. I have not won."}
{MESSAGE (Karen) (portraits/karen.png) (Karen)
_"That's what I meant. You have not won, great super killing machine, so you have lost."}
{ELSE}
{TWO_END_IFs}
{END_IF}
{ELSE}
{END_IF}
{VARIABLE ano_competition end}
{VARIABLE ano_competition_k 0}
{END_IF}
{IF ano_bug_fix equals yes}
{CLEAR_VARIABLE ano_bug_fix}
{VARIABLE ano_competition start}
{END_IF_WITHOUT_ELSE}
#enddef

@cooljeanius
Copy link
Collaborator Author

I think one way to deal with the part about the dialogue being seen so rarely is simply to add more of it, i.e., ensure all of the branches in the code that are currently empty have something in them.

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Dec 22, 2021
@cooljeanius
minor commentary update
0fe1b0b 
mostly for nemaara/A_New_Order#19
@cooljeanius
Copy link
Collaborator Author

cooljeanius/A_New_Order@0fe1b0b doesn't really fix this, but it'd be a step, at least

cooljeanius referenced this issue in cooljeanius/A_New_Order-1 Mar 25, 2022
@cooljeanius
additional work porting to BfW 1.16
c8087e8 
This ought to be equivalent to cooljeanius/A_New_Order@43565fe..44013a3
Bugs addressed, in order of the commits in my repo addressing them:
Addresses #16 (doesn't fix it entirely, though)
Closes #30
Closes #18
Closes #15
Closes #31
Closes cooljeanius/A_New_Order#12
Doesn't actually do anything about #24, despite adding a comment referring to it
Closes #39
Doesn't really do anything about #19, despite adding comments referring to it
@cooljeanius cooljeanius mentioned this issue Mar 25, 2022
Merged
@cooljeanius
Copy link
Collaborator Author

cooljeanius/A_New_Order@0fe1b0b doesn't really fix this, but it'd be a step, at least

it's now part of PR #43

@cooljeanius
Copy link
Collaborator Author

cooljeanius/A_New_Order@0fe1b0b doesn't really fix this, but it'd be a step, at least

it's now part of PR #43

...which is now merged (issue still remains unfixed, though)

@cooljeanius cooljeanius added the enhancement New feature or request label May 29, 2022
@cooljeanius cooljeanius added the help wanted Extra attention is needed label Aug 16, 2022
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Mar 3, 2023
@cooljeanius
S14 updates, etc.
6953359 
- give @Toranks a credits entry
- crop Akladian Lord sprite, to avoid warnings about it being the wrong size
- additional debug messages for the Lorin/Karen killing competition (see issue nemaara/A_New_Order#19 for reference)
- team coloring for caged Reme
@cooljeanius cooljeanius mentioned this issue Mar 4, 2023
Merged
@cooljeanius
Copy link
Collaborator Author

#117 is another step towards addressing this, but I still don't really like it, so I'm keeping the messages from it hidden behind debug mode...

cooljeanius added a commit that referenced this issue Mar 7, 2023
@cooljeanius
Merge pull request #117 from cooljeanius/middle_scenarios_tinkering
e439458 
- add @Toranks to the credits
- new portrait for Kyobaine's winter clothing, contributed by OneHourLate, a.k.a. Mells or ohlyf (from Discord, who I also commissioned my last few portraits from)
- I made an attempt at improving the issue #19 situation, but it didn't exactly work out to my liking, so it's hidden behind debug mode for now.
- New debug mode contextual menu option for displaying messages from arbitrary units, for the purposes of testing issue #16 
- Add a macro that I thought I'd included in #109 (and even used there), but looks like I actually forgot... (it's for giving experience to units)
- New scenario! This commit includes S15c, "Raedwood East", which is probably enough to fix issue #72 for now (the scenario still isn't fully complete yet, but it's finished enough for the purposes of closing that issue)
- Mark more units as unrenamable. Closes issue #114 
- Adjust recruitment patterns. Closes issue #116 
- fix #112 
- Something for issue #7 that I thought I'd already submitted in a previous PR (but, actually hadn't)
@cooljeanius
Copy link
Collaborator Author

#117 is another step towards addressing this, but I still don't really like it, so I'm keeping the messages from it hidden behind debug mode...

ok, merged in e439458 (the base issue here still remains, though)

cooljeanius added a commit that referenced this issue Aug 25, 2024
@cooljeanius
Merge pull request #19 from cooljeanius/dependabot/submodules/utils/w…
c44b557 
…esnoth-map-diff-d55df4e

Bump utils/wesnoth-map-diff from `08c0260` to `d55df4e`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cooljeanius