Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are still some objectives lists that don't specify gold_carryover amount #14

Open
cooljeanius opened this issue Aug 14, 2021 · 10 comments
Open

There are still some objectives lists that don't specify gold_carryover amount #14

cooljeanius opened this issue Aug 14, 2021 · 10 comments
Labels
enhancement New feature or request
Milestone
1.8.0

Comments

@cooljeanius
Copy link
Collaborator

cooljeanius commented Aug 14, 2021 •
edited
Loading

Most other scenarios put [gold_carryover] in their objectives, so it is rather unusual not to see it here.
git grep gold_carryover turns up nothing.
@cooljeanius
Copy link
Collaborator Author

cooljeanius commented Aug 14, 2021 •
edited
Loading

Oh, same thing with the {TURNS_RUN_OUT} too, btw (although I can probably fix that easily enough on my own, as it wouldn't require verifying anything like the gold carryover would)

@cooljeanius
Copy link
Collaborator Author

Oh, same thing with the {TURNS_RUN_OUT} too, btw (although I can probably fix that easily enough on my own, as it wouldn't require verifying anything like the gold carryover would)

OK so in PR #17 I think I handled most of the scenarios that needed the {TURNS_RUN_OUT} macro (at least the ones with explicit time over events); the original issue of gold carryover still remains though.

@cooljeanius
Copy link
Collaborator Author

cooljeanius commented May 8, 2022 •
edited
Loading

Note that the default carryover percentage when left unspecified is 80%: see https://wiki.wesnoth.org/ScenarioWML or https://wiki.wesnoth.org/DirectActionsWML#.5Bendlevel.5D

@cooljeanius
Copy link
Collaborator Author

Similar bug for FtF: cooljeanius/Flight_Freedom#7

@cooljeanius cooljeanius added enhancement New feature or request good first issue Good for newcomers labels May 29, 2022
cooljeanius added a commit that referenced this issue Feb 27, 2023
@cooljeanius
Merge pull request #105 from cooljeanius/first_few_scenarios_Toranks_…
d4c0d74 
…feedback

Addresses some feedback from @Toranks

Changes include:
- addresses issue #7
- clarify Barnon's gold mechanic a bit further (still might need a further update for issue #14 though)
- extra debug messages for reinforcement scattering in S04
- ensure Gawen is really always poisoned in the first scenario
- some additional tuning of the second scenario
- fix team coloring of kneeling Akladian lords in the coronation cutscene (S03)
- additional recruiting space in Barnon on NORMAL, too
- fix Hoyre returning on NIGHTMARE; closes issue #78
@cooljeanius
Copy link
Collaborator Author

@Toranks reminded me about this issue when playing through the Battle of Barnon; do we want to ensure the carryover is always 100% there so that only the additional custom hand-coded "discount" gets applied to Lorin's gold?

@Toranks
Copy link
Contributor

Toranks commented Feb 27, 2023

Having played the battle of bannon for the second time, the huge money discount caused by the 80% plus difficulty reduction is quite noticeable. It would be nice to convert it to 100% as well to avoid confusion. If possible, do the conversion in the victory event instead of in the next stage, so that money carried from one stage to another is reflected directly in the final carryover report, more clear to the player.

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Feb 27, 2023
@cooljeanius
Update 04_Battle_of_Barnon.cfg
d1ae873 
set carryover_percentage to 100 as per discussion in nemaara/A_New_Order#14 with @Toranks
(the objectives still don't list this yet, though)
@cooljeanius
Copy link
Collaborator Author

Having played the battle of bannon for the second time, the huge money discount caused by the 80% plus difficulty reduction is quite noticeable. It would be nice to convert it to 100% as well to avoid confusion.

OK, carryover converted to 100 in #109; the basic issue here of matching the objective notes with the actual carryover in every scenario still remains, though

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Apr 6, 2024
@cooljeanius
objectives updates, part 1 (WIP)
901977f 
(untested)
see nemaara/A_New_Order#14
@cooljeanius cooljeanius added this to the 1.7.0 milestone Apr 7, 2024
@cooljeanius cooljeanius self-assigned this Apr 7, 2024
@cooljeanius
Copy link
Collaborator Author

One annoying thing here is all of the nonlinear portions (e.g. all the branches from S14's large-scale strategical map) all have options to return to a signpost to try a different scenario, which has a full carryover, which is different from the normal objectives, which... don't? I think they just have standard carryovers instead... not quite sure how to handle the objectives for such situations...

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Apr 8, 2024
@cooljeanius
campaign now loads again
3972ffe 
did some more tweaking of objectives for nemaara/A_New_Order#14
also added some additional translator comments for nemaara/A_New_Order#182
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Apr 8, 2024
@cooljeanius
a few more objectives updates
a31cc48 
again, see nemaara/A_New_Order#14
@cooljeanius cooljeanius mentioned this issue May 19, 2024
Merged
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Aug 19, 2024
@cooljeanius
objectives: note scenarios with unlimited turns
4599f58 
...and with early finish bonuses.
See nemaara/A_New_Order#14
@cooljeanius
Copy link
Collaborator Author

#194 at least partially addresses this, although there are still a few places where I haven't verified the carryover amounts yet...

cooljeanius added a commit that referenced this issue Aug 24, 2024
@cooljeanius
Fixes for issues targeted for Milestone 1.7.0 (#194)
db6054d 
* Start of another PR
  - Another attempt at fixing #23 again; cc @Toranks and @knyghtmare
  - Refer to Gawen as "Haldric" in S08 for #182
  - Dune is probably ok to reference explicitly by name in the translators' comments
  - try Lorin stat changes suggested in #179
* a number of additional minor fixes
  - be more explicit about carryover amounts for issue #14 (still need to check scenarios 20 thru 26)
  - check for Lorin's presence in Kyobaine Easter Egg for issue #150
  - attempt at improving the situation for issue #165 (still broken)
  - Update commentary re: issue #79
  - Updates to dialogue and translation notes for issue #182
  - Enables Raedwood East for normal gameplay for issue #129
  - Give Lorin unique bridge destruction dialogue for issue #187
* a few minor tweaks
* a few additional updates
  - add luacheck workflow
  - add a few additional changelog items
  - dialogue changes for checkbox 2 of issue #32
* Add Rob Roe death message
  - see issue #199
* some more changes from other repo
  - more spellchecking
  - use proper portrait for Kyobaine in her death message
  - tried to add a new fix for #79, but it doesn't seem to work...
  - a few more footnotes
* latest batch of changes from other repo
(squashed)
@cooljeanius cooljeanius modified the milestones: 1.7.0, 1.8.0 Aug 24, 2024
@cooljeanius
Copy link
Collaborator Author

OK I think I've got as much of this done for 1.7.0 as I'm going to; retargeting the remaining part to 1.8.0

@cooljeanius cooljeanius removed the good first issue Good for newcomers label Aug 24, 2024
@cooljeanius cooljeanius removed their assignment Aug 25, 2024
@cooljeanius cooljeanius changed the title None of the objectives list gold_carryover amount There are still some objectives lists that don't specify gold_carryover amount Aug 25, 2024
@cooljeanius cooljeanius changed the title There are still some objectives lists that don't specify gold_carryover amount There are still some objectives lists that don't specify gold_carryover amount Aug 25, 2024
cooljeanius added a commit that referenced this issue Aug 25, 2024
@cooljeanius
Merge pull request #14 from cooljeanius/dependabot/submodules/utils/w…
d0fa62a 
…esnoth-map-diff-4ed1015

Bump utils/wesnoth-map-diff from `21f0790` to `4ed1015`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
2 participants
@cooljeanius @Toranks