Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements #100

Open
cooljeanius opened this issue Feb 25, 2023 · 8 comments
Open

Achievements #100

cooljeanius opened this issue Feb 25, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@cooljeanius
Copy link
Collaborator

So, mainline Wesnoth is adding support for achievements. ANO actually already kinda has its own homegrown achievement system, except here you don't find out which achievements you've earned until the final scenario, when your points are all tallied up. If we add support for mainline-style achievements, too, should they be for the same things you get points for? If so, should they trigger when you first complete the action required (like normal achievements), or only when you get points at the end? How much do we want to worry about spoilers here?

@cooljeanius cooljeanius added enhancement New feature or request question Further information is requested labels Feb 25, 2023
@cooljeanius
Copy link
Collaborator Author

Also, now that #109 added a version of DiD's macro to give experience to units, do we want to consider using that in the same places as the ones that would grant achievements/points, or different ones?

@cooljeanius
Copy link
Collaborator Author

Also, now that #109 added a version of DiD's macro to give experience to units, do we want to consider using that in the same places as the ones that would grant achievements/points, or different ones?

er, correction: the actual definition of the macro looks like it didn't make it in until #117

@cooljeanius
Copy link
Collaborator Author

@nemaara now that you've been doing a few achievement-related PRs for mainline Wesnoth, anything to add here?

@nemaara
Copy link
Owner

nemaara commented Apr 10, 2023

I can make some guidelines for achievements but probably not going to work on them at the moment. Feel free to open some PRs or put some ideas here.

@cooljeanius
Copy link
Collaborator Author

Well, ok, so, let me reformulate the questions here:

  • Should the achievements be for the same things you get points for in the final tally in S30, "Final", or should they be for different things?
  • If we end up giving achievements for the same things that you get points for, should the achievements be awarded at the same time as you complete the action required, or not until the end when you finally get the point for it?

@nemaara
Copy link
Owner

nemaara commented Apr 10, 2023

I leave that to you, but I like the point system at the end. If for example you rescue Reme and we add that as an achievement, you should get the achievement on the spot. I also wouldn't mind adding a couple achievements for points, like reach 30 points or something.

@cooljeanius
Copy link
Collaborator Author

I also wouldn't mind adding a couple achievements for points, like reach 30 points or something.

oh right, that reminds me that I still need to figure out what the maximum number of points one can get actually is... (I think it might actually be unbounded?)

@cooljeanius
Copy link
Collaborator Author

@ForestDragon-wesnoth reports getting 18 points on his most recent playthrough...

@cooljeanius cooljeanius added this to the 1.8.0 milestone Aug 24, 2024
@cooljeanius cooljeanius self-assigned this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants