fix: prevent unintended input replacement in reusable workflows with workflow_dispatch when using workflow_call #2502
Conversation
…workflow_dispatch inputs Closes: nektos#2464
mahmud2011
changed the title
|
|
This reverts commit 6345596.
|
@ChristopherHX I reverted it. |
There was a problem hiding this comment.
Yes I confirm that you no longer remove the feature I mentioned.
Could you please add a pkg/runner/testdata/<testname>/workflow_dispatch.yml and a reusable workflow in pkg/runner/testdata/.github/workflows/<testworkflow>.yml that assert that your change works now and in a year?
Then a new line like
Line 306 in 9135745
where the first workflow_dispatch should be replaced by <testname>
in the workflow_dispatch.yml do a
uses: ./.github/workflows/<testworkflow>.yml
see uses https://github.com/nektos/act/tree/master/pkg/runner/testdata/uses-workflow for an example.
didn't test yet as you always need two approvals, I take me some time for actually testing this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2502 +/- ##
===========================================
+ Coverage 61.56% 75.01% +13.45%
===========================================
Files 53 62 +9
Lines 9002 10008 +1006
===========================================
+ Hits 5542 7508 +1966
+ Misses 3020 1937 -1083
- Partials 440 563 +123 ☔ View full report in Codecov by Sentry. |
|
Thanks. I was about to write the tests. |
More tests are welcome, I reapprove if needed as the most active member. However we need to wait for one other member to make a merge happen. |
Closes: #2464