From 5a5c1c372d7c992349238a0fefe9249f71ec544f Mon Sep 17 00:00:00 2001 From: mucha55 Date: Tue, 7 Jan 2020 16:51:04 -0600 Subject: [PATCH] KOJO-167,169,175 | Clarify the process pool server start command exit code --- src/Console/Command/Process/Pool/Server/Start.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Console/Command/Process/Pool/Server/Start.php b/src/Console/Command/Process/Pool/Server/Start.php index d0d3d170..eabf9a14 100644 --- a/src/Console/Command/Process/Pool/Server/Start.php +++ b/src/Console/Command/Process/Pool/Server/Start.php @@ -38,10 +38,9 @@ public function _execute(): int $arguments[] = self::OPT_YSDP . $servicesYmlFilePath; } pcntl_exec(__DIR__ . '/../../../../../../bin/kojo', $arguments); - $this->_getOutput()->writeln('An error occurred trying to start the process pool server.'); - // currently there is no graceful shutdown flow for kojo, it works until terminated - // if, in the future, we want such a flow, and want to expose its success via exit code, we will need to make changes here + // this code will only get executed if the pcntl_exec() fails, so exit with a non-zero code + $this->_getOutput()->writeln('An error occurred trying to start the process pool server.'); return 255; }