From ae73b68b50608c1e97f7d9845ef505b2b6e531b9 Mon Sep 17 00:00:00 2001 From: alexberryman Date: Mon, 24 Jun 2024 11:11:46 -0400 Subject: [PATCH] Fix $serviceName being null --- charts/neighborhoods-apps/CHANGELOG.md | 2 ++ charts/neighborhoods-apps/Chart.yaml | 2 +- charts/neighborhoods-apps/templates/http-ingress.yaml | 8 ++++---- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/charts/neighborhoods-apps/CHANGELOG.md b/charts/neighborhoods-apps/CHANGELOG.md index 0748b53..b97c366 100644 --- a/charts/neighborhoods-apps/CHANGELOG.md +++ b/charts/neighborhoods-apps/CHANGELOG.md @@ -1,4 +1,6 @@ # Changelog +## 2.14.1 +- Fix $serviceName being null ## 2.14.0 - Swap from ALB to NGINX ingress ## 2.13.0 diff --git a/charts/neighborhoods-apps/Chart.yaml b/charts/neighborhoods-apps/Chart.yaml index b0627b8..8fd25c8 100644 --- a/charts/neighborhoods-apps/Chart.yaml +++ b/charts/neighborhoods-apps/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 description: Neighborhoods standard chart setup with Nginx fronting the HTTP deployment name: neighborhoods-app -version: 2.14.0 +version: 2.14.1 kubeVersion: ">=1.23.0-0" home: https://github.com/neighborhoods/neighborhoods-chart sources: diff --git a/charts/neighborhoods-apps/templates/http-ingress.yaml b/charts/neighborhoods-apps/templates/http-ingress.yaml index d8fea6b..1d03c72 100644 --- a/charts/neighborhoods-apps/templates/http-ingress.yaml +++ b/charts/neighborhoods-apps/templates/http-ingress.yaml @@ -24,7 +24,7 @@ spec: - pathType: {{ .Values.ingress.pathType | default "Prefix" | quote }} backend: service: - name: {{ $serviceName | quote }} + name: {{ .Values.service.name }} port: number: {{ $servicePort }} {{- end }} @@ -36,7 +36,7 @@ spec: pathType: {{ .Values.ingress.pathType | default "Prefix" | quote }} backend: service: - name: {{ $serviceName | quote }} + name: {{ .Values.service.name }} port: number: {{ $servicePort }} {{- range .Values.ingress.extraHosts }} @@ -49,12 +49,12 @@ spec: pathType: {{ .Values.ingress.pathType | default "Prefix" | quote }} - backend: service: - name: {{ $serviceName | quote }} + name: {{ .Values.service.name }} port: number: {{ $servicePort }} {{- end }} tls: - hosts: - {{ required ".Values.ingress.host must be specified when .Values.ingress.enabled is true" .Values.ingress.host | quote }} - secretName: {{ $serviceName | quote }} + secretName: {{ .Values.service.name }} {{ end }}