Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fontVariants #2732

Open
1 task done
benharri opened this issue Oct 31, 2024 · 0 comments
Open
1 task done

Add missing fontVariants #2732

benharri opened this issue Oct 31, 2024 · 0 comments
Labels

Comments

@benharri
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

additional font variants are available in react native
https://github.com/facebook/react-native/blob/e5dd7d68bf264669fc5c4ce5e69b24249d28558b/packages/react-native/Libraries/StyleSheet/StyleSheetTypes.d.ts#L440C17-L472C24

applying any of the missing ones in react-native-web causes them to be silently ignored

Expected behavior

fontVariants are applied correctly

Steps to reproduce

add a fontVariant that isn't available

| 'small-caps'
| 'oldstyle-nums'
| 'lining-nums'
| 'tabular-nums'
| 'proportional-nums'

Test case

https://codesandbox.io/p/sandbox/cool-resonance-3kqps8?workspaceId=af88e762-6261-40a3-a475-c631585426e7

Additional comments

No response

@benharri benharri added the bug label Oct 31, 2024
benharri added a commit to benharri-forks/react-native-web that referenced this issue Oct 31, 2024
tentative fix for necolas#2732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant