Support Configuration Cache #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalcolea
commented
Oct 20, 2023
| * This is temporary until config cache serialization is fixed when writing tests | ||
| * More in https://github.com/gradle/gradle/issues/25898 | ||
| */ | ||
| tasks.withType(Test).configureEach { |
There was a problem hiding this comment.
This is temporary until gradle/gradle#25898 is addressed
rpalcolea
commented
Oct 20, 2023
| @@ -48,6 +48,9 @@ abstract class GitVersioningIntegrationSpec extends IntegrationSpec { | |||
| build/ | |||
| gradle.properties'''.stripIndent() | |||
|
|
|||
| // Enable configuration cache :) | |||
| new File(projectDir, 'gradle.properties') << '''org.gradle.configuration-cache=true'''.stripIndent() | |||
There was a problem hiding this comment.
This enables config cache for all integration tests
rpalcolea
force-pushed
the
configuration-cache-support
branch
3 times, most recently
from
cc294a2
to
08b937a
Compare
rpalcolea
force-pushed
the
configuration-cache-support
branch
from
08b937a
to
c2edfac
Compare
| import org.gradle.api.tasks.TaskAction | ||
| import org.gradle.work.DisableCachingByDefault | ||
|
|
||
| @DisableCachingByDefault(because = "Publishing related tasks should not be cacheable") |
src/main/groovy/nebula/plugin/release/git/base/ReleaseTask.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: OdysseusLives <[email protected]>
OdysseusLives
approved these changes
Oct 23, 2023
| ByteArrayOutputStream error = new ByteArrayOutputStream() | ||
| List<String> commandLineArgs = ["git", "--git-dir=${rootDir.absolutePath}/.git".toString(), "--work-tree=${rootDir.absolutePath}".toString()] | ||
| commandLineArgs.addAll(args) | ||
| execOperations.exec { |
| abstract ExecOperations getExecOperations() | ||
|
|
||
| @CompileDynamic | ||
| String executeGitCommand(Object ... args) { |
| * These read only git commands use ValueSource approach for configuration cache | ||
| * @see {@link https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:external_processes} | ||
| */ | ||
| abstract class GitReadCommand implements ValueSource<String, GitCommandParameters> { |
There was a problem hiding this comment.
💯 on documenting all these classes for usability and posterity
|
|
||
| /** | ||
| * These git commands involve creating or pushing tags | ||
| * Because these happen at task execution level, we are fine with not using ValueSource |
There was a problem hiding this comment.
Great call-out! Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should support config cache by following https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:external_processes when executing Git
All the integration tests apply the following now:
which will enforce configuration cache during tests across all the specs