Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from url to service on mutating/validating webhook handlers with nebari workflow controller #2854

Open
Adam-D-Lewis opened this issue Nov 14, 2024 · 0 comments
Open

Switch from url to service on mutating/validating webhook handlers with nebari workflow controller #2854

Adam-D-Lewis opened this issue Nov 14, 2024 · 0 comments
Labels
needs: triage 🚦 Someone needs to have a look at this issue and triage

Comments

@Adam-D-Lewis
Copy link
Member

Context

nebari/src/_nebari/stages/kubernetes_services/template/modules/kubernetes/services/argo-workflows/main.tf

Line 416 in 87ed92b

"url" = "https://${var.external-url}/${local.argo-workflows-prefix}/mutate"

The k8s docs say we should use service instead of url. The issue is we'll need to handle ssl termination at the webhook. Maybe cert manager could help with this?

Value and/or benefit

Follow best practices

Anything else?

No response
@Adam-D-Lewis Adam-D-Lewis added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: triage 🚦 Someone needs to have a look at this issue and triage
Projects
🪴 Nebari Project Management
Status: New 🚦
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Adam-D-Lewis