Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always add commit hash to version.build for /status endpoint #12722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

always add commit hash to version.build for /status endpoint #12722

wants to merge 1 commit into from

Conversation

qiweiii
Copy link

@qiweiii qiweiii commented Jan 12, 2025

fix #12624

After locally adding a tag 5.5.5

before changes:

curl -s localhost:3030/status | jq -Mr .version
{
  "version": "trunk",
  "build": "5.5.5",
  "rustc_version": "1.83.0"
}

after changes:

curl -s localhost:3030/status | jq -Mr .version
{
  "version": "trunk",
  "build": "5.5.5-0-g1dd1b0a92",
  "rustc_version": "1.83.0"
}

@qiweiii qiweiii requested a review from a team as a code owner January 12, 2025 13:10
@qiweiii qiweiii requested a review from akhi3030 January 12, 2025 13:10
@staffik staffik requested a review from andrei-near January 13, 2025 10:32
@staffik
Copy link
Contributor

staffik commented Jan 13, 2025

@andrei-near Could you take a look if it does not break something with release process?
Maybe adding a commit field would be a safer way, if validators potentially rely on the build field not having the commit hash for release build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhi3030 akhi3030 Awaiting requested review from akhi3030 akhi3030 is a code owner automatically assigned from near/nearcore-codeowners

@andrei-near andrei-near Awaiting requested review from andrei-near

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add git commit to the /status endpoint
2 participants
@qiweiii @staffik