From 85178ab67ff103a2fa27c04ec660ddcfd99d8ae5 Mon Sep 17 00:00:00 2001 From: Andy Haynes Date: Tue, 28 Jun 2022 10:35:42 -0700 Subject: [PATCH 1/3] feat(ci): add lint to prebuild step --- Jenkinsfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Jenkinsfile b/Jenkinsfile index ff4286b408..d8fb65bb14 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -46,6 +46,7 @@ pipeline { } steps { dir("$WORKSPACE/packages/frontend") { + sh 'yarn lint' sh 'yarn install --frozen-lockfile' } } From 9ac28bcf5c706a30c5dbd5c1a79e1bc1961a2589 Mon Sep 17 00:00:00 2001 From: Andy Haynes Date: Tue, 28 Jun 2022 10:37:18 -0700 Subject: [PATCH 2/3] feat: lint on push --- packages/frontend/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/frontend/package.json b/packages/frontend/package.json index b31f520b02..e1d9b6c3b7 100644 --- a/packages/frontend/package.json +++ b/packages/frontend/package.json @@ -76,8 +76,8 @@ "fix": "eslint --ext .js --ext .jsx . --fix", "storybook": "start-storybook -p 6006", "build-storybook": "build-storybook", - "prepush": "yarn run test", - "precommit": "concurrently \"yarn run fix\" \".githooks/format-json\"", + "prepush": "concurrently \"yarn run test\" \"yarn lint\"", + "precommit": ".githooks/format-json", "preinstall": "npx only-allow yarn" }, "browserslist": [ From 9d048f45641674cefdd0cbd40332fd83871d8770 Mon Sep 17 00:00:00 2001 From: andy-haynes <36863574+andy-haynes@users.noreply.github.com> Date: Tue, 28 Jun 2022 12:35:14 -0700 Subject: [PATCH 3/3] fix: lint after install Co-authored-by: Morgan McCauley --- Jenkinsfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Jenkinsfile b/Jenkinsfile index d8fb65bb14..e57a00041c 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -46,8 +46,8 @@ pipeline { } steps { dir("$WORKSPACE/packages/frontend") { - sh 'yarn lint' sh 'yarn install --frozen-lockfile' + sh 'yarn lint' } } }