Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix 2FA being enable-able without confirmation #374

Open
MaximusHaximus opened this issue Apr 21, 2021 · 0 comments
Open

BUG: fix 2FA being enable-able without confirmation #374

MaximusHaximus opened this issue Apr 21, 2021 · 0 comments

Comments

@MaximusHaximus
Copy link
Contributor

MaximusHaximus commented Apr 21, 2021

Patrick stumbled across a bug in 2FA flow:
It seems you’re able to enable 2fa without number/email confirmation if I’ve started the recovery link method setup (email/phone). Confirmation isn’t required, only that you’ve sent a recovery link w code. I think it’s not checking for a “confirmed” recovery method before deploying the multisig contract in the contract helper.

Discovered that the response in the 2fa flow from the contract helper was hard-coded to confirmed: true even if the matched 2fa method was not yet actually confirmed (still has securityCode value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant