Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port opentelemetry code to multichain codebase #428

Open
Tracked by #326
ppca opened this issue Jan 19, 2024 · 6 comments
Open
Tracked by #326

Port opentelemetry code to multichain codebase #428

ppca opened this issue Jan 19, 2024 · 6 comments
Assignees

Comments

@ppca
Copy link
Contributor

ppca commented Jan 19, 2024

Mostly involves porting the tracing-opentelemetry gluecode from the old codebase: https://github.com/near/mpc-recovery/blob/develop/mpc-recovery/src/logging.rs

We also used to have tracing endpoints, but not sure if that's relevant anymore as we are not exposing any user-facing API anymore: https://github.com/near/mpc-recovery/blob/develop/mpc-recovery/src/leader_node/mod.rs#L119-L122

@ppca ppca moved this from Backlog to In Progress in Emerging Technologies Jan 19, 2024
@ppca ppca self-assigned this Jan 19, 2024
@volovyks volovyks moved this from In Progress to Selected in Emerging Technologies Feb 13, 2024
@ppca
Copy link
Contributor Author

ppca commented Apr 3, 2024

We now have our node logs in gcp, for example: multichain-dev-1

@volovyks volovyks closed this as completed Apr 4, 2024
@github-project-automation github-project-automation bot moved this from Selected to Done in Emerging Technologies Apr 4, 2024
@volovyks
Copy link
Collaborator

volovyks commented Apr 4, 2024

The logging functionality works, but it is spammed with DEBUG level logs. Can we please change the default severity level to INFO? I've tried severity>=INFO but it has not helped.

@volovyks volovyks reopened this Apr 4, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Emerging Technologies Apr 4, 2024
@ppca
Copy link
Contributor Author

ppca commented May 15, 2024

Seems the SEVERITY level only applies to log from GCP side, not logs from multichain service. I'm working with Kody on this

@ppca
Copy link
Contributor Author

ppca commented May 22, 2024

Looks like we can port severity level by using this library to set up the global logging subscriber: https://github.com/NAlexPear/tracing-stackdriver

@volovyks
Copy link
Collaborator

Is it compatible with our current tracing APIs? If not, I would not invest time in it now. Feel free to move it back to backlog if it's time-consuming.

@ppca
Copy link
Contributor Author

ppca commented May 23, 2024

not entirely sure. I'll move it back to backlog for now.

@ppca ppca moved this from In Progress to Backlog in Emerging Technologies May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants