lockup_contract: some view methods crashing or giving incorrect values

[telezhnaya]

https://github.com/near/core-contracts/blob/master/lockup/src/getters.rs#L118

    /// Get the amount of tokens that are already vested or released, but still locked due to lockup.
    /// Takes raw vesting schedule, in case the internal vesting schedule is private.
    pub fn get_locked_vested_amount(&self, vesting_schedule: VestingSchedule) -> WrappedBalance {
        (self.get_locked_amount().0 - self.get_unvested_amount(vesting_schedule).0).into()
    }

If lockup starts earlier than vesting, we crash because we have a negative result after subtracting

[frol]

Well, nice finding, but ...

If lockup starts earlier than vesting, we crash because we have a negative result after subtracting

There is never a case where the lockup is earlier than vesting just according to common sense.

[telezhnaya]

I am sorry, I misinformed you above, there's nothing about termination. I deleted my wrong statements above not to misinform anyone else. The bug exists, though.

Also found incorrect get_owners_balance
https://github.com/near/core-contracts/blob/master/lockup/src/getters.rs#L163
It says

It includes vested and extra tokens that may have been deposited to this account, but excludes locked tokens.

In fact, there's nothing about vesting logic inside.

And get_liquid_owners_balance
https://github.com/near/core-contracts/blob/master/lockup/src/getters.rs#L176
Same error, no check whether tokens were vested or not