Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large requests raise an error when Sys.sleep is called #35

Open
jpeacock29 opened this issue Apr 16, 2024 · 0 comments
Open

Large requests raise an error when Sys.sleep is called #35

jpeacock29 opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jpeacock29
Copy link
Contributor

When large requests are made, CitationChaser pauses between requests to avoid overloading the LENS API. However, when Sys.sleep(60 - t) is hit, t is not defined (besides it's definition in base R as a matrix transpose...). I fixed this locally by replacing 60 - t with 20 (a fixed 20 second sleep period).

I can make a pull request with this fix, but I couldn't understand what the intended functionality was exactly. I noticed a t_ref was defined and measured the duration of the last API call.

@DrMattG DrMattG assigned DrMattG and nealhaddaway and unassigned DrMattG Apr 17, 2024
@DrMattG DrMattG added the bug Something isn't working label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants