Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to update gtest to newer version #576

Open
mikir opened this issue Feb 26, 2024 · 0 comments
Open

Consider to update gtest to newer version #576

mikir opened this issue Feb 26, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@mikir
Copy link
Contributor

mikir commented Feb 26, 2024

We are currently using gtest version 1.11.0 from Jun 2021.

It would be good to update it to newer version. However, we have observed some compilation problems on some MinGW distributions using new version 1.12.0. This should be investigated and clarified.

Beside of that, the version 1.12.0 is the last one which still supports C++11.

The main problem of old gtest version 1.11.0 is the following cmake warning:

CMake Deprecation Warning at /home/runner/work/zserio/zserio/3rdparty/cpp/googletest/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.
  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
CMake Deprecation Warning at /home/runner/work/zserio/zserio/3rdparty/cpp/googletest/googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.
  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

The problem above could be a potential problem in the future.

@mikir mikir added the enhancement New feature or request label Feb 26, 2024
@mikir mikir added this to the Backlog milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant