Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapget::Service tile requests support basic filtering functionality. #34

Open
MisterGC opened this issue Sep 26, 2023 · 0 comments
Open

Comments

@MisterGC
Copy link
Contributor

mapget::Service::request currently allows basic queries based on mapId, layerId, and tiles. This issue aims to extend the existing API to include basic feature filtering capabilities. Implementing this enhancement will allow users to test the function's accuracy and scalability more efficiently. Special attention will be given to meeting general scalability requirements.

Extended 'tiles' Endpoint Example

// Extract from mapget's updated README
// Fetch streamed features based on strict constraints.
// Support for Accept-Encoding text/jsonl or application/binary

+ POST /tiles(list<{
    mapId: string,
    layerId: string,
    tileIds: list<TileId>,
    maxKnownFieldIds* 
  }>, filter: optional<string>): 
  bytes<TileLayerStream>

Acceptance Criteria:

  • Implement filtering in both local and Http mapget services
  • Automated tests for both services, with:
    • Customizable request options
    • Metrics on time spent fetching and filtering data
  • Performance regression detection using standardized tests on defined hardware/target

Open Questions:

  • How to restrict the filter language in this step?
  • Is it also intended to use this functionality for functions like 'viewport-based' filtering?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant