modules without within does nothing

[parsonsmatt]

We had an hlint rule like this:

modules:
  - name: [Network.HTTP.Client]
    message: "Please import OpenTelemetry.Instrumentation.HttpClient instead so that requests may be properly traced."

This rule doesn't do anything. The intention was to ban the import of the module. To make it work, we needed to do within: [].

I think it makes sense to infer a within: [] when it is unspecified. The point of within is that it is a list of modules that are opting-out of the rule, and so we are sort of defaulting a missing within to within: **.* which feels way worse.

[zliu41]

This is related to point 2 in this comment. I agree within shouldn't be required for a restriction to take effect.