Added the deploy configs #51
Open
+187
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ickynavigator ! This is a lovely idea to extend the configuration. Just have a few comments in the code I'll be adding 🤘 |
ndimatteo
reviewed
Nov 1, 2023
|
|
||
| You can pass in deployments that should already be added into the app (refresh the site after the initial load). | ||
|
|
||
| **Make sure the projectNames are unique.** |
There was a problem hiding this comment.
Why would the project name need to be unique across specified deployments? In most instances (including your example below) the projectName is the same. Let me know if I'm missing something!
There was a problem hiding this comment.
This was because I had a check to create a new project when the user refreshed the page
I need to make sure that I don't already have the project created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50