Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Postgresql #408

Open
ndelvalle opened this issue Apr 21, 2024 · 16 comments · May be fixed by #477
Open

Migrate to Postgresql #408

ndelvalle opened this issue Apr 21, 2024 · 16 comments · May be fixed by #477
Assignees

Comments

@ndelvalle
Copy link
Owner

ndelvalle commented Apr 21, 2024

After doing some research I think I will give https://github.com/SeaQL/sea-orm a try and implement it.

Interesting reads about different ORM options:

@opeolluwa
Copy link
Collaborator

Do you want help with this?

@ndelvalle
Copy link
Owner Author

@opeolluwa Yes, but I still haven’t decided what to use for PostgreSQL. I’m leaning more towards Diesel over SeaORM—it seems simpler and doesn’t clutter the code with ORM-related elements everywhere. I also need to put more effort into my #458 PR to make it more stable so that others can contribute, as it’s currently a bit messy.
Do you have strong opinions about these ORMs?

@opeolluwa
Copy link
Collaborator

yes, I've used both in production environment.
My opinion is that, diesel is more battle tested than SeaORM, especially looking at the stats, on the other end, SeaORM seems more promising.

Also on the other end, Diesel isn't async-first unlike, SeaORM.

@opeolluwa
Copy link
Collaborator

Do you want me to look at this

@ndelvalle
Copy link
Owner Author

@opeolluwa I’m currently using diesel-async for async support, and it seems to be working correctly. If you’re interested in continuing the work, that would be fantastic. I haven’t had much time lately to make progress, so any help would be greatly appreciated!

@opeolluwa
Copy link
Collaborator

I'll see what can be done

@opeolluwa
Copy link
Collaborator

@ndelvalle do you want to use diese-async or I should revamp with sea-orm

@ndelvalle
Copy link
Owner Author

@opeolluwa i think using async diesel is the best idea.

@opeolluwa
Copy link
Collaborator

alright

@opeolluwa
Copy link
Collaborator

I'll put it up locally tomorrow!

@opeolluwa
Copy link
Collaborator

@ndelvalle would you be kind to tag the branch you're working on

@ndelvalle
Copy link
Owner Author

@ndelvalle would you be kind to tag the branch you're working on

I just added you as a collaborator, feel free to keep working on the same branch or tag it.

@opeolluwa
Copy link
Collaborator

awesome thanks

@opeolluwa
Copy link
Collaborator

@ndelvalle the use-diesel branch has a handful of issues, I'm going to squash it and incrementally make PR to the main branch till all it is all setup

@ndelvalle
Copy link
Owner Author

ndelvalle commented Sep 22, 2024

@ndelvalle the use-diesel branch has a handful of issues, I'm going to squash it and incrementally make PR to the main branch till all it is all setup

Yeah @opeolluwa , we don't need to use the use-diesel branch, you can create another one and we can work on that one.

@opeolluwa
Copy link
Collaborator

Awesome!

I've done that

@opeolluwa opeolluwa linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants