Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB QoL Changes #25

Open
3 tasks
ninjaprawn opened this issue Jan 24, 2017 · 2 comments
Open
3 tasks

DB QoL Changes #25

ninjaprawn opened this issue Jan 24, 2017 · 2 comments
Assignees
@ninjaprawn
Labels
enhancement

Comments

@ninjaprawn
Copy link
Collaborator

ninjaprawn commented Jan 24, 2017 •
edited by Jackywathy
Loading

Let's make the DB code easy to read and use!

  • Classes will reference other classes if required, instead of their being public code which uses the ID to find the class we want
  • Move some static methods to instance methods to improve clarity
  • Include setters which directly communicate with the database to set the correct value

Feel free to put down anything else that should be added!
(All changes will be done in the db branch)
@ninjaprawn ninjaprawn self-assigned this Jan 24, 2017
@ninjaprawn
Copy link
Collaborator Author

BTW merge conflicts are probably inevitable :)

@tracey-le
Copy link
Collaborator

tracey-le commented Jan 24, 2017 •
edited
Loading

awesome of you!! 😄

(I did not know that 'QoL changes' means 'Quality of Life changes' until I looked it up 🤔 😯 😮 😂 hehe 😛)

@ninjaprawn ninjaprawn mentioned this issue Jan 25, 2017
Closed
@tracey-le tracey-le mentioned this issue Jan 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninjaprawn ninjaprawn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ninjaprawn @tracey-le