Skip to content

Commit eb7c7f7

Browse files
committed
update for singularity fix
1 parent ce3b472 commit eb7c7f7

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

dist/run_fcsgx.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@ def __init__(self, args):
3939
self.args = args
4040
self.args.container_db = Path(args.container_db)
4141

42+
def safe_exec(self, args):
43+
if self.args.debug:
44+
print(" ".join(args))
45+
subprocess.run(args, shell=False, check=True, text=True, stdout=sys.stdout, stderr=sys.stderr)
46+
4247
def retrieve_singularity_image(self, local_filename):
4348
ctx = ssl.create_default_context()
4449
ctx.check_hostname = False
@@ -100,7 +105,7 @@ def run_retrieve_db(self):
100105

101106
retrieve_db_args = [
102107
container_engine,
103-
"run",
108+
"run" if container_engine == "docker" else "exec",
104109
mount_arg,
105110
str(expanded_gxdb) + ":" + str(self.args.container_db),
106111
*extra_docker_args,
@@ -111,11 +116,7 @@ def run_retrieve_db(self):
111116
str(self.args.container_db / gxdb_name),
112117
*extra_db_args,
113118
]
114-
subprocess.run(
115-
retrieve_db_args,
116-
shell=False,
117-
check=True,
118-
)
119+
self.safe_exec(retrieve_db_args)
119120

120121
def run_gx(self):
121122
expanded_gxdb = Path(os.path.realpath(os.path.dirname(self.args.gx_db)))
@@ -137,7 +138,7 @@ def run_gx(self):
137138

138139
docker_args = [
139140
container_engine,
140-
"run",
141+
"run" if container_engine == "docker" else "exec",
141142
mount_arg,
142143
str(expanded_gxdb) + ":" + str(self.args.container_db),
143144
mount_arg,
@@ -167,9 +168,7 @@ def run_gx(self):
167168
if self.args.env_file:
168169
docker_args.extend(["--env-file", str(Path("/sample-volume/") / self.args.env_file)])
169170

170-
if self.args.debug:
171-
print(docker_args)
172-
subprocess.run(docker_args, shell=False, check=True)
171+
self.safe_exec(docker_args)
173172

174173
def run_verify_checksums(self):
175174
expanded_gxdb = Path(os.path.realpath(os.path.dirname(self.args.gx_db)))
@@ -186,7 +185,7 @@ def run_verify_checksums(self):
186185

187186
docker_args = [
188187
container_engine,
189-
"run",
188+
"run" if container_engine == "docker" else "exec",
190189
mount_arg,
191190
str(expanded_gxdb) + ":" + str(self.args.container_db),
192191
docker_image,
@@ -196,9 +195,7 @@ def run_verify_checksums(self):
196195
str(self.args.container_db / gxdb_name),
197196
"--debug",
198197
]
199-
if self.args.debug:
200-
print(docker_args)
201-
subprocess.run(docker_args, shell=False, check=True)
198+
self.safe_exec(docker_args)
202199

203200
def run(self):
204201
self.run_retrieve_db()

0 commit comments

Comments
 (0)