Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning some QR codes will crash the application #275

Open
webwarrior-ws opened this issue Apr 22, 2024 · 5 comments
Open

Scanning some QR codes will crash the application #275

webwarrior-ws opened this issue Apr 22, 2024 · 5 comments

Comments

@webwarrior-ws
Copy link
Contributor

webwarrior-ws commented Apr 22, 2024

Steps to reproduce:

  1. Open GWallet Android app
  2. Navigate to Send page
  3. Click "scan" button
  4. Scan QR code that decodes to text "litecoin:ygfdty" (starts with "litecoin:" but has incorrect LTC address)

Current results:
Application crashes

Expected results:
An error is shown, but app keeps working.

The reason is that ParseAddressOrUrl function will raise an exception in that case.

failwith <| SPrintF1 "Address started with 'bitcoin:' but an address could not be extracted: %s" addressOrUrl

@knocte
Copy link
Member

knocte commented Apr 22, 2024

Please check the handbook on how to file bugs.

@knocte knocte changed the title Scanning some qr codes will crash the application Scanning some QR codes will crash the application Apr 22, 2024
@knocte
Copy link
Member

knocte commented Apr 22, 2024

Scan QR code that decodes to text that starts with "bitcoin:" or "litecoin:" but doesn't contain valid bitcoin/litecoin address

Give a specific example. The specific one that you have tested.

@webwarrior-ws
Copy link
Contributor Author

Sample barcode:
barcode_sample

@knocte
Copy link
Member

knocte commented Apr 22, 2024

Sample barcode:

Please edit steps to reproduce to:

  • include the text that his barcode decodes to (in step 4).
  • change steps to be numbered, like it says in the handbook.

@knocte
Copy link
Member

knocte commented Apr 23, 2024

Scan QR code that decodes to text "litecoin:ygfdty" (starts with "litecoin:" but has incorrect LTC address)

Let's investigate what happens in the case of scanning a bitcoin QR code (when in a Bitcoin's SendPage): does BitcoinUrlBuilder return an Address property that is null? Let's test with "bitcoin:ygfdty".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants