From dea99be4fc79579bb6517d23f2143273c611874f Mon Sep 17 00:00:00 2001 From: "Andres G. Aragoneses" Date: Tue, 13 Feb 2024 11:53:25 +0800 Subject: [PATCH] Fsdk/FSharpUtil: add TODO to ReRaise [no ci] Inspired by https://twitter.com/knocte/status/1756181551900152123 --- Fsdk/FSharpUtil.fs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Fsdk/FSharpUtil.fs b/Fsdk/FSharpUtil.fs index 64aaab77..24bbf97f 100644 --- a/Fsdk/FSharpUtil.fs +++ b/Fsdk/FSharpUtil.fs @@ -217,8 +217,10 @@ module FSharpUtil = return failwith "unreachable" } - // FIXME: we should not need this workaround anymore when this gets addressed: + // NOTE: no need for this workaround anymore after this gets addressed: // https://github.com/fsharp/fslang-suggestions/issues/660 + // TODO: actually, reraise in async blocks is not that important; rather use Result! + // so let's mark this as [] with this recommendation let ReRaise(ex: Exception) : Exception = (ExceptionDispatchInfo.Capture ex).Throw() failwith "Should be unreachable"