Network: try-with with specific exceptions

Previously, this block had a generic try-with which is dangerous since it can cause unwanted behaviours and cause confusion for future developers.
nblockchain · Nov 21, 2022 · d16f92f · d16f92f
1 parent d750cfe
commit d16f92f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/NOnion/Exceptions.fs b/NOnion/Exceptions.fs
@@ -26,6 +26,9 @@ type CircuitTruncatedException internal (reason: DestroyReason) =
 type CircuitDestroyedException internal (reason: DestroyReason) =
     inherit NOnionException(sprintf "Circuit got destroyed, reason %A" reason)
 
+type CircuitDecryptionFailedException internal () =
+    inherit NOnionException(sprintf "Circuit Decryption Failed")
+
 type TimeoutErrorException internal () =
     inherit NOnionException("Time limit exceeded for operation")
 

diff --git a/NOnion/Network/TorCircuit.fs b/NOnion/Network/TorCircuit.fs
@@ -336,7 +336,8 @@ and TorCircuit
                                  node)
                     | None ->
                         announceDeath()
-                        failwith "Decryption failed!"
+
+                        raise <| CircuitDecryptionFailedException()
 
                 decryptMessage encryptedRelayCell.EncryptedData nodes
             | _ -> failwith "Unexpected state when receiving relay cell"

diff --git a/NOnion/Network/TorGuard.fs b/NOnion/Network/TorGuard.fs
@@ -332,14 +332,15 @@ type TorGuard private (client: TcpClient, sslStream: SslStream) =
                             try
                                 do! circuit.HandleIncomingCell cell
                             with
-                            | ex ->
+                            | :? CircuitDecryptionFailedException as ex ->
                                 sprintf
                                     "TorGuard: exception when trying to handle incoming cell type=%i, ex=%s"
                                     cell.Command
                                     (ex.ToString())
                                 |> TorLogger.Log
 
                                 self.KillChildCircuits()
+                            | ex -> return raise <| FSharpUtil.ReRaise ex
                         | None ->
                             self.KillChildCircuits()
                             failwithf "Unknown circuit, Id = %i" cid