Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version >= 1.8.0 breaks nbqa 'ruff format' shell command #843

Closed
fvonbergen opened this issue Mar 7, 2024 · 4 comments
Closed

Version >= 1.8.0 breaks nbqa 'ruff format' shell command #843

fvonbergen opened this issue Mar 7, 2024 · 4 comments

Comments

@fvonbergen
Copy link

fvonbergen commented Mar 7, 2024

The following commit 2303a49df1a15d73fdbd525f41e37c3b3f82fcf8 breaks ruff nbqa usage of the form:

nbqa 'ruff format' .

Besides the main_command we could also analyze the subcommands list.

    if main_command == "ruff":
        subcommand = subcommands if len(subcommands) == 1 and subcommands[0] in ["check", "format"] else "check"
        sub_commands.insert(0, subcommand)
@MarcoGorelli
Copy link
Collaborator

thanks @fvonbergen for the report! fix incoming

@MarcoGorelli
Copy link
Collaborator

@all-contributors please add @fvonbergen for bugs

Copy link
Contributor

@MarcoGorelli

I've put up a pull request to add @fvonbergen! 🎉

@fvonbergen
Copy link
Author

Thank you for the fast response 🏃 @MarcoGorelli !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants