Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/tools/test_ruff_works.py fails as ruff <path> was deprecated in ruff 0.3.0 #837

Closed
funkeleinhorn opened this issue Mar 1, 2024 · 3 comments · Fixed by #840
Closed

Comments

@funkeleinhorn
Copy link
Contributor

ruff 0.3.0 deprecated ruff <path> in favor of ruff check <path>. See this PR for more info. Because tests/tools/test_ruff_works.py uses ruff <path> the test now fails. The test should be updated to use ruff check <path>.

@MarcoGorelli
Copy link
Collaborator

thanks - want to make a pr?

@funkeleinhorn
Copy link
Contributor Author

funkeleinhorn commented Mar 1, 2024

I just stumbled across this while updating the ruff Nix Package. I quickly replaced ruff with ruff check in test_ruff_works.py but the tests test_ruff_isort and test_pylint_works still fail. Sadly I dont have the time to dive in the codebase of another project so I will probably not be able to make a pull request here in the near future. So probably it will be better/faster if someone how is using/already contributed here picks this up.

@funkeleinhorn
Copy link
Contributor Author

Found the time to look into it and created a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants