Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add Operation throughput and latency metrics by mbean. #841

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

FEAT: Add Operation throughput and latency metrics by mbean. #841

wants to merge 1 commit into from

Conversation

brido4125
Copy link
Collaborator

@brido4125 brido4125 commented Nov 21, 2024 •
edited
Loading

πŸ”— Related Issue

https://github.com/jam2in/arcus-works/issues/615

⌨️ What I did

μ•„λž˜μ˜ 정보λ₯Ό MBean을 톡해 λ…ΈμΆœμ‹œμΌœ jmx-exportλ₯Ό 톡해 μˆ˜μ§‘λ  수 μžˆλ„λ‘ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
λ©”νŠΈλ¦­λ“€μ˜ μˆ˜μ§‘ λ‹¨μœ„λŠ” ν•˜λ‚˜μ˜ java process μž…λ‹ˆλ‹€.
즉, N개의 ArcusClient 전뢀에 λŒ€ν•œ μˆ˜μ§‘λ°©μ‹μž…λ‹ˆλ‹€.

  • Throughput
    • Completed : 연산에 μ„±κ³΅ν•œ Op 개수
    • Canceled : λ‚΄λΆ€ / μ™ΈλΆ€(μ‚¬μš©μž)에 μ˜ν•΄μ„œ μ·¨μ†Œλœ Op 개수
    • Timeouted : timeout이 λ°œμƒν•œ Op 개수
  • Latency : 졜근 10,000개의 연산에 λŒ€ν•œ μ•„λž˜ ν•­λͺ©λ³„ Latency μˆ˜μ§‘
    • avgLatency
    • minLatency
    • maxLatency
    • 25% Latency
    • 50% Latency
    • 75% Latency

κ·ΈλΌνŒŒλ‚˜ λŒ€μ‹œλ³΄λ“œλŠ” 이슈 내에 κΈ°μž…λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.

@brido4125 brido4125 self-assigned this Nov 21, 2024
@brido4125 brido4125 requested a review from uhm0311 November 21, 2024 02:08
uhm0311
uhm0311 requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@uhm0311 uhm0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1μ°¨ 리뷰 μ˜κ²¬μž…λ‹ˆλ‹€.

src/main/java/net/spy/memcached/metrics/OpLatencyMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpLatencyMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpLatencyMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpLatencyMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpLatencyMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpThroughputMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/protocol/BaseOperationImpl.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpThroughputMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpThroughputMonitor.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpThroughputMonitor.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@uhm0311 uhm0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2μ°¨ 리뷰 μ˜κ²¬μž…λ‹ˆλ‹€.

src/main/java/net/spy/memcached/metrics/LatencyMetricsSnapShot.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/metrics/OpThroughputMonitorMBean.java Show resolved Hide resolved
uhm0311
uhm0311 requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@uhm0311 uhm0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ΄κ²ƒλ§Œ μˆ˜μ •ν•˜λ©΄ 될 것 κ°™μŠ΅λ‹ˆλ‹€.

src/main/java/net/spy/memcached/metrics/LatencyMetricsSnapShot.java Outdated Show resolved Hide resolved
@brido4125 brido4125 requested a review from jhpark816 November 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhm0311 uhm0311 uhm0311 approved these changes

@jhpark816 jhpark816 Awaiting requested review from jhpark816

Assignees

@brido4125 brido4125

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brido4125 @uhm0311