INTERNAL: Remove public ArcusClient constructor.

Author: brido4125

src/main/java/net/spy/memcached/ArcusClient.java

@@ -340,6 +340,39 @@ protected static ArcusClient getInstance(ConnectionFactory cf,
     return new ArcusClient(cf, name, addrs);
   }
 
+  /**
+   * Create an Arcus client for the given memcached server addresses.
+   * Recommend only invoked with proxy arcus server.
+   * @param addrs socket addresses for the proxy memcached servers
+   * @param cfb   connection factory builder to configure connections for this client
+   * @return Arcus client instance
+   * @throws IOException
+   */
+  public static ArcusClient createArcusClient(List<InetSocketAddress> addrs,
+                                              ConnectionFactoryBuilder cfb)
+          throws IOException {
+    return new ArcusClient(cfb.build(), addrs);
+  }
+
+  /**
+   * Create an Arcus client pool for the given memcached server addresses.
+   * Recommend only invoked with proxy arcus server.
+   * @param addrs socket addresses for the proxy memcached servers
+   * @param cfb   connection factory builder to configure connections for this client
+   * @param size  pool size
+   * @return Arcus client pool instance
+   * @throws IOException
+   */
+  public static ArcusClientPool createArcusClientPool(List<InetSocketAddress> addrs,
+                                                      ConnectionFactoryBuilder cfb, int size)
+          throws IOException {
+    ArcusClient[] clients = new ArcusClient[size];
+    for (int i = 0; i < size; i++) {
+      clients[i] = new ArcusClient(cfb.build(), addrs);
+    }
+    return new ArcusClientPool(size, clients);
+  }
+
   /**
    * Create an Arcus client for the given memcached server addresses.
    *
@@ -348,7 +381,7 @@ protected static ArcusClient getInstance(ConnectionFactory cf,
    * @param addrs socket addresses for the memcached servers
    * @throws IOException if connections cannot be established
    */
-  public ArcusClient(ConnectionFactory cf, String name, List<InetSocketAddress> addrs)
+  protected ArcusClient(ConnectionFactory cf, String name, List<InetSocketAddress> addrs)
           throws IOException {
     super(cf, name, addrs);
 
@@ -369,7 +402,7 @@ public ArcusClient(ConnectionFactory cf, String name, List<InetSocketAddress> ad
    * @param addrs socket addresses for the memcached servers
    * @throws IOException if connections cannot be established
    */
-  public ArcusClient(ConnectionFactory cf, List<InetSocketAddress> addrs)
+  protected ArcusClient(ConnectionFactory cf, List<InetSocketAddress> addrs)
           throws IOException {
     this(cf, DEFAULT_ARCUS_CLIENT_NAME + "-" + CLIENT_ID.getAndIncrement(), addrs);
   }

src/test/manual/net/spy/memcached/collection/BaseIntegrationTest.java

@@ -120,7 +120,7 @@ public void connectionLost(SocketAddress sa) {
     };
     cfb.setInitialObservers(Collections.singleton(obs));
 
-    mc = new ArcusClient(cfb.build(), AddrUtil.getAddresses(ARCUS_HOST));
+    mc = ArcusClient.createArcusClient(AddrUtil.getAddresses(ARCUS_HOST), cfb);
     latch.await();
   }