Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scan conflict edge cases #377

Open
6 tasks
navaronbracke opened this issue Apr 7, 2023 · 0 comments
Open
6 tasks

Handle scan conflict edge cases #377

navaronbracke opened this issue Apr 7, 2023 · 0 comments
Labels
bug Something isn't working enhancement An enhancement to an existing feature

Comments

@navaronbracke
Copy link
Owner

If a conflict occurs during scanning and later during the scan that conflict is actually cleared by having all owners resolve through other devices that are found, the app still goes to the conflicts screen.

Instead we should do the following:

  • skip the conflicting owners page if the conflicts were automatically resolved later in the scan
  • handle the case where two devices with the same name, but different mac address are found
    • display this device as skipped, because a device with the same name was already found
    • do not add the owners of this device to the list of owners
  • let the conflicting scan results observe when their conflicting owners are resolved later
    • if a conflicting owner is removed because it is resolved later -> update for the new list of conflicting owners (this should decrement)
@navaronbracke navaronbracke added bug Something isn't working enhancement An enhancement to an existing feature labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement An enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant