Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll excluded term input fields into view when the bottom view insets change #364

Open
navaronbracke opened this issue Apr 2, 2023 · 1 comment
Labels
enhancement An enhancement to an existing feature

Comments

@navaronbracke
Copy link
Owner

navaronbracke commented Apr 2, 2023

The inputs for excluded terms on the settings page (both the add term & edit term input) could use improved handling for avoiding the keyboard. Currently, only the edit excluded term field has some handling of this, but it does not always work.

We should investigate if we can hoist the view insets observing part out of the excluded term input fields.

When the excluded term input field calls its ensureVisible() implementation, it might be visible but behind the keyboard, which defeats the purpose of the method. Secondly, if the scrollable content does not include enough height to avoid the keyboard height, scrolling won't have any effect in certain cases.

Also remove the cached viewInsets in the input field.

@navaronbracke navaronbracke added the enhancement An enhancement to an existing feature label Apr 2, 2023
@navaronbracke navaronbracke changed the title Scroll add excluded term input field into view Scroll excluded term input fields into view when the bottom view insets change Apr 6, 2023
@navaronbracke
Copy link
Owner Author

Something we can investigate is using maintainBottomViewPadding in a SafeArea widget together with resizeToAvoidBottomViewPadding. Essentially we need resizeToAvoidBottomViewPadding: true but on the list, not the scaffold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant