Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip gogoproto from the main protocol.proto #7

Open
mcqueary opened this issue Feb 24, 2016 · 0 comments
Open

Strip gogoproto from the main protocol.proto #7

mcqueary opened this issue Feb 24, 2016 · 0 comments

Comments

@mcqueary
Copy link

Ideally protocol.proto should have no external cross-language dependencies. Right now, it imports gogoprotobuf, which requires that you have a go environment installed on your build system and gogoprotobuf installed. For a java or C# client, this doesn't make sense. Protobuf allows for language-specific options (e.g. java_package, go_package, etc), but apparently not language-specific imports.

If possible, we should find a way to isolate the Go-specific parts of the .proto file and put them in a separate .proto.

The goal is to have a .proto file that does not depend on go, and does not require editing in order to use in other non-go projects.

EDIT: we aren't the first ones to deal with this. The folks at cockroachdb solved it by putting their proto file in a separate repo along with a Makefile and scripts to produce clean proto files: https://github.com/cockroachdb/cockroach-proto/

Barring a better idea, we could follow this approach.

@mcqueary mcqueary added this to the Needs Discussion milestone Mar 15, 2016
@mcqueary mcqueary changed the title protocol.proto depends on go Strip gogoproto from the main protocol.proto Mar 21, 2016
@mcqueary mcqueary added the ready label Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant