Make S3 bucket creation conditional

Author: paulschwarzenberger

docs/architecture.md

@@ -17,6 +17,7 @@ However, as CloudFormation is a declarative syntax for provisioning resources, e
 - Deployment helper SNS topic
 - Deployment helper Lambda function
 - AWS Backup Service-linked IAM Role
+- S3 Terraform state bucket for deployments to workload accounts
 
 ## Central account resources per deployment
 

locals.tf

@@ -1,6 +1,6 @@
 locals {
   terraform_state_bucket_name = (
-    var.terraform_state_bucket_name == "" ? module.tf_state_bucket.s3_bucket_name :
-    var.terraform_state_bucket_name
+    var.terraform_state_bucket_name != "" ? var.terraform_state_bucket_name :
+    module.tf_state_bucket[0].s3_bucket_name
   )
 }

main.tf

@@ -55,6 +55,7 @@ module "deployment" {
 
 module "tf_state_bucket" {
   source = "./modules/s3"
+  count  = var.terraform_state_bucket_name == "" ? 1 : 0
 
   central_account_resource_name_prefix = var.central_account_resource_name_prefix
 }