Generalise S3 module

Author: paulschwarzenberger

modules/deployment-helper/locals.tf

@@ -1,4 +1,6 @@
 locals {
+  bucket_prefix = "${lower(var.central_account_resource_name_prefix)}tf-state-"
+
   terraform_state_bucket_name = (
     var.terraform_state_bucket_name != "" ? var.terraform_state_bucket_name :
     module.tf_state_bucket[0].s3_bucket_name

modules/deployment-helper/s3.tf

@@ -2,5 +2,5 @@ module "tf_state_bucket" {
   source = "../s3"
   count  = var.terraform_state_bucket_name == "" ? 1 : 0
 
-  central_account_resource_name_prefix = var.central_account_resource_name_prefix
+  bucket_prefix = local.bucket_prefix
 }

modules/s3/locals.tf

@@ -1,5 +1,5 @@
 resource "aws_s3_bucket" "bucket" {
-  bucket_prefix = local.bucket_prefix
+  bucket_prefix = var.bucket_prefix
   force_destroy = var.force_destroy
 
   tags = var.tags

modules/s3/main.tf

@@ -1,10 +1,10 @@
-variable "central_account_resource_name_prefix" {
+variable "bucket_prefix" {
   type        = string
-  description = "Central account resource name prefix, e.g. aws-backup-"
+  description = "S3 Terraform state bucket name prefix, e.g. aws-backup-tf-state-"
 
   validation {
-    condition     = length(var.central_account_resource_name_prefix) <= 28
-    error_message = "central_account_resource_name_prefix must be less than or equal to 28 characters"
+    condition     = length(var.bucket_prefix) <= 37
+    error_message = "bucket name prefix must be less than or equal to 37 characters"
   }
 }