Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomically - require() of ES Module #178

Open
davekobrenski opened this issue Apr 20, 2023 · 4 comments
Open

atomically - require() of ES Module #178

davekobrenski opened this issue Apr 20, 2023 · 4 comments

Comments

@davekobrenski
Copy link

In version 5.0.0, the settings.js file attempts to require atomically (ES module) instead of import, and thus throws an error. Seems like an easy fix?

require() of ES Module [...]/atomically/dist/index.js from [...]/electron-settings/dist/settings.js not supported.

Instead change the require of index.js in [...]/settings.js to a dynamic import() which is available in all CommonJS modules.

I see that version 5.0.0 is only a few hours old :)

@nathanbuchar
Copy link
Owner

Woopsies, sorry about that. Thank you for flagging.

@quanglam2807 FYI

@quanglam2807
Copy link
Collaborator

Thanks for reporting. It's likely we might have to move the project to ES Module.

I used webpack so I didn't encounter this issue at all.

@Mad-Chemist
Copy link

Was just running into this issue and realized it's a fresh release hah

@nathanbuchar
Copy link
Owner

In the meantime, I've assigned the @latest npm dist tag back to [email protected]. @quanglam2807, let me know when this issue has been fixed and we're ready to publish this again under v5.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants