Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Onigmo patch obsolete #2051

Open
herwinw opened this issue May 28, 2024 · 3 comments
Open

Make the Onigmo patch obsolete #2051

herwinw opened this issue May 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@herwinw
Copy link
Member

herwinw commented May 28, 2024

One of my "I want to do this some day but not right now" tasks.

We currently have a one line patch for Onigmo to enable the use of uppercase letters in capture group names, but disable the Ruby bindings.

It would be nice if we could push a patch upstream to split this compile option, where defining RUBY would imply the extra range of capture groups, but it should be possible to enable that extra range separately.

@herwinw
Copy link
Member Author

herwinw commented May 31, 2024

https://github.com/k-takata/Onigmo

Latest release in January 2019, last commit in February 2021. I'm not sure if this project is still actively maintained.

@seven1m
Copy link
Member

seven1m commented May 31, 2024

Interesting. There is a newer commit to the Onigmo embedded in CRuby here: ruby/ruby@1d2d25d

...and that commit was not upstreamed to Onigmo proper. 🤔

@herwinw
Copy link
Member Author

herwinw commented May 31, 2024

Issue started with an attempt to remove a patch, issue is turning into an attempt to add a second patch 🤣

@seven1m seven1m added the enhancement New feature or request label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants