Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert_swig's regex for matching qualified template instantiations is incomplete #1751

Open
dbankieris opened this issue Jul 30, 2024 · 2 comments · May be fixed by #1752
Open

convert_swig's regex for matching qualified template instantiations is incomplete #1751

dbankieris opened this issue Jul 30, 2024 · 2 comments · May be fixed by #1752
Assignees

Comments

@dbankieris
Copy link
Contributor

This line is looking for template instantiations that are qualified with the scope resolution operator (::). The pattern matches instantiations with only a single operator (such as bar::Foo) but not those with multiple operators (such as baz::bar::Foo). I believe the correct pattern is ^\w*(::\w+)+<

@dbankieris dbankieris self-assigned this Jul 30, 2024
@dbankieris dbankieris linked a pull request Jul 30, 2024 that will close this issue
@sharmeye
Copy link
Contributor

sharmeye commented Aug 6, 2024

Is there a scenario you're encountering that makes this change necessary? Because we don't support nested namespaces (or classes) so there's not really a situation (we don't think) where this would come into play. Please provide examples if you are having a problem with how it is currently implemented that this change fixes.

@dbankieris
Copy link
Contributor Author

TrickCAT uses lots of nested namespaces, which didn't cause any problems until f8a079e. #1753 restores enough support for nested namespaces to allow TrickCAT to build within Trick again. Consider it a small step on the path from "we don't support nested namespaces at all" to "we partially support nested namespaces."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants