c++ instances allocated via MemoryManager do not call destructors when deleted

[excaliburtb]

Similar to #1301 but for a different reason. I found that if I declare a c++ class using memory manager (i.e. TMM_declare_var_s for my specific test), the alloc_info instance that gets allocated to track it always has the allocation set for TRICK_ALLOC_MALLOC. Since that enum TRICK_ALLOC_MALLOC = 0, it's either a mistake and is just resulting to the default.. OR, allocations are intentionally tracked as MALLOC instead of TRICK_ALLOC_NEW for some reason. git grepping through the code, I see no attempt to set the alloc_type to anything except for the DataRecordGroup. So, it doesn't matter which API I use, Trick will never treat it as anything other than a malloc.

[sharmeye]

Thanks, we'll look into this and let you know.

[jmpenn]

It looks like we might have just overlooked adding "alloc_type = TRICK_ALLOC_NEW"
in the two occurrences where we set "language = Language_CPP" in :

void* Trick::MemoryManager::declare_var(TRICK_TYPE type,std::string user_type_name, int n_stars, std::string var_name, int n_cdims, int *cdims);

,in MemoryManager_declare_var.cpp.

I'll add this, and test to ensure that it works as intended.

[jmpenn]

Specifically, my proposed fix is:
In MemoryManager_declare_var.cpp

After line 48, add:
TRICK_ALLOC_TYPE alloc_type;

After lines 128 & 141, add:
alloc_type = TRICK_ALLOC_NEW;
144: alloc_type = TRICK_ALLOC_NEW;

After line 158, add:
new_alloc->alloc_type = alloc_type;

[excaliburtb]

that looks good to me

[jmpenn]

Complication: It looks like the generated io_src allocation routines sometimes call calloc() [even when marked CPP], and sometimes call new(). Need to do more digging.

[excaliburtb]

hmm.. isn't there a io_src_*_destruct routine that gets generated? can't we use those?

[jmpenn]

After interruptions, and complications, and mistakes, I believe I've finally got it.
After call to io_src_allocate_class, allocation_type should instead be set to TRICK_ALLOC_MALLOC.
io_src_allocate_class always uses calloc().

I've made a new pull-request (#1639) for which all of the unit tests pass. These include a new test ( TEST_F(MM_delete_var_unittest, CXX_object_constructor_destructor)) that specifically verifies that the destructor is being called.