Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timing that variable server sends out information #1412

Open
stephenmontgomerysmith opened this issue Dec 6, 2022 · 5 comments
Open

Comments

@stephenmontgomerysmith
Copy link

I found that increasing the priority of IP packets from the variable server really improved the timing when working in realtime situations. I did this using the setsocklet(SOL_SOCKET, SO_PRIORITY,... function.

Would you like to add this functionality to trick? I have attached a patch for your consideration.
trick-patch.txt

FYI you can also contact me at this email address: [email protected]

@jdeans289
Copy link
Contributor

This looks like a good idea! If you'd like to collaborate on it further, please open a pull request so we can go through the review process. If you'd rather not, we can work on incorporating it ourselves. Let us know!

@stephenmontgomerysmith
Copy link
Author

Do I need permissions to create a pull request?

@jdeans289
Copy link
Contributor

No, you'll create a fork of the Trick repo, add your changes, and open a pull request from there.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

@stephenmontgomerysmith
Copy link
Author

OK, I got it. I didn't realize I was supposed to fork my own copy.

@alexlin0
Copy link
Contributor

alexlin0 commented Feb 2, 2023

By default the variable server does not keep strict timing when sending out messages. It does have a couple of options to send out packets tied to the main thread of execution which could improve timing and data homogeneity. See the Time Homogenous or Synchronous Data section of the variable server documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants